Fix parameter name editable flag for existing function parameters #667
Merged
pasindufernando1 merged 2 commits intoballerina-platform:1.5.xfrom Feb 2, 2026
Merged
Fix parameter name editable flag for existing function parameters #667pasindufernando1 merged 2 commits intoballerina-platform:1.5.xfrom
pasindufernando1 merged 2 commits intoballerina-platform:1.5.xfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where function parameter names were incorrectly marked as editable: true in existing function parameters. The fix removes an unconditional .editable() call in the FormBuilder.parameterWithDescription() method, allowing the conditional logic to properly set the editable flag based on whether the parameter has a source code location (token is non-null).
Changes:
- Removed unconditional
.editable()call inFormBuilder.parameterWithDescription()method - Updated test expectations to reflect
editable: falsefor existing function parameters with source code locations
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| FormBuilder.java | Removed unconditional .editable() call from parameterWithDescription() method to fix incorrect editable flag |
| function_def2.json | Updated test expectations: parameter variable now has editable: false |
| function_def3.json | Updated test expectations: parameter variables now have editable: false |
| function_def4.json | Updated test expectations: parameter variable now has editable: false |
| function_def5.json | Updated test expectations: parameter variables now have editable: false |
| function_def6.json | Updated test expectations: parameter variables now have editable: false |
| function_def8.json | Updated test expectations: parameter variable now has editable: false |
| function_def13.json | Updated test expectations: parameter variables now have editable: false |
| function_def14.json | Updated test expectations: parameter variables now have editable: false |
| function_def15.json | Updated test expectations: parameter variables now have editable: false |
| np_function_def1.json | Updated test expectations: parameter variables now have editable: false |
| np_function_def2.json | Updated test expectations: parameter variable now has editable: false |
| np_function_def3.json | Updated test expectations: parameter variable now has editable: false |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nipunayf
approved these changes
Feb 2, 2026
Contributor
nipunayf
left a comment
nipunayf
left a comment
There was a problem hiding this comment.
Approving this as a temporary fix; may need to revisit it later.
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes an issue where function parameter names were incorrectly marked as
editable: truein the flowDesignService/functionDefinition API for existing parameters in the source code. The editable flag should only be true for template parameters used when adding new parameters, not for parameters that already exist. Removed the unconditional .editable() call in FormBuilder.parameterWithDescription() so that existing parameters with source code locations now correctly haveeditable: false.Fixes : wso2/product-ballerina-integrator#179
Screen.Recording.2026-01-30.at.15.33.06.mov